[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC for-4.1 24/25] target/ppc: Style fixes for translate
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-ppc] [RFC for-4.1 24/25] target/ppc: Style fixes for translate/vmx-impl.inc.c |
|
Date: |
Mon, 25 Mar 2019 08:48:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/22/19 1:15 AM, David Gibson wrote:
> Signed-off-by: David Gibson <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> target/ppc/translate/vmx-impl.inc.c | 26 +++++++++++++++-----------
> 1 file changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/target/ppc/translate/vmx-impl.inc.c
> b/target/ppc/translate/vmx-impl.inc.c
> index eb10c533ca..bd3ff40e68 100644
> --- a/target/ppc/translate/vmx-impl.inc.c
> +++ b/target/ppc/translate/vmx-impl.inc.c
> @@ -15,7 +15,7 @@ static inline TCGv_ptr gen_avr_ptr(int reg)
> }
>
> #define GEN_VR_LDX(name, opc2, opc3)
> \
> -static void glue(gen_, name)(DisasContext *ctx)
> \
> +static void glue(gen_, name)(DisasContext *ctx)
> \
> {
> \
> TCGv EA;
> \
> TCGv_i64 avr;
> \
> @@ -28,8 +28,10 @@ static void glue(gen_, name)(DisasContext *ctx)
> EA = tcg_temp_new();
> \
> gen_addr_reg_index(ctx, EA);
> \
> tcg_gen_andi_tl(EA, EA, ~0xf);
> \
> - /* We only need to swap high and low halves. gen_qemu_ld64_i64 does
> \
> - necessary 64-bit byteswap already. */
> \
> + /*
> \
> + * We only need to swap high and low halves. gen_qemu_ld64_i64
> \
> + * does necessary 64-bit byteswap already.
> \
> + */
> \
> if (ctx->le_mode) {
> \
> gen_qemu_ld64_i64(ctx, avr, EA);
> \
> set_avr64(rD(ctx->opcode), avr, false);
> \
> @@ -61,8 +63,10 @@ static void gen_st##name(DisasContext *ctx)
> \
> EA = tcg_temp_new();
> \
> gen_addr_reg_index(ctx, EA);
> \
> tcg_gen_andi_tl(EA, EA, ~0xf);
> \
> - /* We only need to swap high and low halves. gen_qemu_st64_i64 does
> \
> - necessary 64-bit byteswap already. */
> \
> + /*
> \
> + * We only need to swap high and low halves. gen_qemu_st64_i64
> \
> + * does necessary 64-bit byteswap already.
> \
> + */
> \
> if (ctx->le_mode) {
> \
> get_avr64(avr, rD(ctx->opcode), false);
> \
> gen_qemu_st64_i64(ctx, avr, EA);
> \
> @@ -296,7 +300,7 @@ GEN_VXFORM_V(vnand, MO_64, tcg_gen_gvec_nand, 2, 22);
> GEN_VXFORM_V(vorc, MO_64, tcg_gen_gvec_orc, 2, 21);
>
> #define GEN_VXFORM(name, opc2, opc3) \
> -static void glue(gen_, name)(DisasContext *ctx)
> \
> +static void glue(gen_, name)(DisasContext *ctx) \
> { \
> TCGv_ptr ra, rb, rd; \
> if (unlikely(!ctx->altivec_enabled)) { \
> @@ -306,7 +310,7 @@ static void glue(gen_, name)(DisasContext *ctx)
> ra = gen_avr_ptr(rA(ctx->opcode)); \
> rb = gen_avr_ptr(rB(ctx->opcode)); \
> rd = gen_avr_ptr(rD(ctx->opcode)); \
> - gen_helper_##name (rd, ra, rb); \
> + gen_helper_##name(rd, ra, rb); \
> tcg_temp_free_ptr(ra); \
> tcg_temp_free_ptr(rb); \
> tcg_temp_free_ptr(rd); \
> @@ -758,7 +762,7 @@ GEN_VXFORM_DUPI(vspltish, tcg_gen_gvec_dup16i, 6, 13);
> GEN_VXFORM_DUPI(vspltisw, tcg_gen_gvec_dup32i, 6, 14);
>
> #define GEN_VXFORM_NOA(name, opc2, opc3) \
> -static void glue(gen_, name)(DisasContext *ctx)
> \
> +static void glue(gen_, name)(DisasContext *ctx) \
> { \
> TCGv_ptr rb, rd; \
> if (unlikely(!ctx->altivec_enabled)) { \
> @@ -767,9 +771,9 @@ static void glue(gen_, name)(DisasContext *ctx)
> } \
> rb = gen_avr_ptr(rB(ctx->opcode)); \
> rd = gen_avr_ptr(rD(ctx->opcode)); \
> - gen_helper_##name (rd, rb); \
> + gen_helper_##name(rd, rb); \
> tcg_temp_free_ptr(rb); \
> - tcg_temp_free_ptr(rd); \
> + tcg_temp_free_ptr(rd); \
> }
>
> #define GEN_VXFORM_NOA_ENV(name, opc2, opc3) \
> @@ -943,7 +947,7 @@ static void gen_vsldoi(DisasContext *ctx)
> rb = gen_avr_ptr(rB(ctx->opcode));
> rd = gen_avr_ptr(rD(ctx->opcode));
> sh = tcg_const_i32(VSH(ctx->opcode));
> - gen_helper_vsldoi (rd, ra, rb, sh);
> + gen_helper_vsldoi(rd, ra, rb, sh);
> tcg_temp_free_ptr(ra);
> tcg_temp_free_ptr(rb);
> tcg_temp_free_ptr(rd);
>
- [Qemu-ppc] [RFC for-4.1 18/25] target/ppc: Style fixes for mmu_helper.c, (continued)
- [Qemu-ppc] [RFC for-4.1 24/25] target/ppc: Style fixes for translate/vmx-impl.inc.c, David Gibson, 2019/03/21
- Re: [Qemu-ppc] [RFC for-4.1 24/25] target/ppc: Style fixes for translate/vmx-impl.inc.c,
Cédric Le Goater <=
- [Qemu-ppc] [RFC for-4.1 22/25] target/ppc: Style fixes for translate/fp-impl.inc.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 17/25] target/ppc: Style fixes for mmu-hash64.[ch], David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 23/25] target/ppc: Style fixes for translate/vsx-impl.inc.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 15/25] target/ppc: Style fixes for misc_helper.c, David Gibson, 2019/03/21