[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash3
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-ppc] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch] |
Date: |
Mon, 25 Mar 2019 07:35:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/22/19 1:15 AM, David Gibson wrote:
> Signed-off-by: David Gibson <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> target/ppc/mmu-hash32.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
> index e8562a7c87..f83944b78c 100644
> --- a/target/ppc/mmu-hash32.c
> +++ b/target/ppc/mmu-hash32.c
> @@ -27,7 +27,7 @@
> #include "mmu-hash32.h"
> #include "exec/log.h"
>
> -//#define DEBUG_BAT
> +/* #define DEBUG_BAT */
>
> #ifdef DEBUG_BATS
> # define LOG_BATS(...) qemu_log_mask(CPU_LOG_MMU, __VA_ARGS__)
> @@ -228,8 +228,10 @@ static int ppc_hash32_direct_store(PowerPCCPU *cpu,
> target_ulong sr,
> qemu_log_mask(CPU_LOG_MMU, "direct store...\n");
>
> if ((sr & 0x1FF00000) >> 20 == 0x07f) {
> - /* Memory-forced I/O controller interface access */
> - /* If T=1 and BUID=x'07F', the 601 performs a memory access
> + /*
> + * Memory-forced I/O controller interface access
> + *
> + * If T=1 and BUID=x'07F', the 601 performs a memory access
> * to SR[28-31] LA[4-31], bypassing all protection mechanisms.
> */
> *raddr = ((sr & 0xF) << 28) | (eaddr & 0x0FFFFFFF);
> @@ -266,8 +268,9 @@ static int ppc_hash32_direct_store(PowerPCCPU *cpu,
> target_ulong sr,
> return 1;
> case ACCESS_CACHE:
> /* dcba, dcbt, dcbtst, dcbf, dcbi, dcbst, dcbz, or icbi */
> - /* Should make the instruction do no-op.
> - * As it already do no-op, it's quite easy :-)
> + /*
> + * Should make the instruction do no-op. As it already do
> + * no-op, it's quite easy :-)
> */
> *raddr = eaddr;
> return 0;
> @@ -519,8 +522,10 @@ int ppc_hash32_handle_mmu_fault(PowerPCCPU *cpu, vaddr
> eaddr, int rwx,
> if (rwx == 1) {
> new_pte1 |= HPTE32_R_C; /* set changed (dirty) bit */
> } else {
> - /* Treat the page as read-only for now, so that a later write
> - * will pass through this function again to set the C bit */
> + /*
> + * Treat the page as read-only for now, so that a later write
> + * will pass through this function again to set the C bit
> + */
> prot &= ~PAGE_WRITE;
> }
>
>
- Re: [Qemu-ppc] [RFC for-4.1 19/25] target/ppc: Style fixes for monitor.c, (continued)
- [Qemu-ppc] [RFC for-4.1 09/25] target/ppc: Style fixes for gdbstub.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 08/25] target/ppc: Style fixes for excp_helper.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 11/25] target/ppc: Style fixes for kvm_ppc.h and kvm.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 06/25] target/ppc: Style fixes for fpu_helper.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch], David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 05/25] target/ppc: Style fixes for int_helper.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 01/25] spapr: Support NVIDIA V100 GPU with NVLink2, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 12/25] target/ppc: Style fixes for machine.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 02/25] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h", David Gibson, 2019/03/21