[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 3/3] ppc/pnv: use IEC binary prefixes to repres
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-ppc] [PATCH v2 3/3] ppc/pnv: use IEC binary prefixes to represent sizes |
|
Date: |
Mon, 25 Feb 2019 19:56:33 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote:
> Using IEC binary prefixes from qemu/units.h provides a more human-friendly
> value
> to size constants.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Murilo Opsfelder Araujo <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> hw/ppc/pnv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index c308ae423a..b6c5d1eff9 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -47,11 +47,11 @@
>
> #include <libfdt.h>
>
> -#define FDT_MAX_SIZE 0x00100000
> +#define FDT_MAX_SIZE (1 * MiB)
>
> #define FW_FILE_NAME "skiboot.lid"
> #define FW_LOAD_ADDR 0x0
> -#define FW_MAX_SIZE 0x00400000
> +#define FW_MAX_SIZE (4 * MiB)
>
> #define KERNEL_LOAD_ADDR 0x20000000
> #define KERNEL_MAX_SIZE (256 * MiB)
>