[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99 |
Date: |
Wed, 9 Jan 2019 15:25:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/9/19 3:20 PM, Paolo Bonzini wrote:
> On 09/01/19 18:28, Daniel P. Berrangé wrote:
>>> so both files include each other, how nice ...
>> If the header files are mutually dependent it makes me wonder what the
>> point of having them split up is ?
>>
>> Feels like either they need to be merged, or they need to be split up
>> and refactored even more to remove the mutual dependancy.
>
> If they include each other only for the typedefs, then prehaps the
> solution is to change the coding style and allow using struct in
> function prototypes. I'm pretty sure there are several examples of this
> already.
Or stick the typedef in <typedefs.h>, instead of trying to find (or
create) some other common header.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH v3 0/2] Force the C standard to gnu99, Thomas Huth, 2019/01/09
- [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Thomas Huth, 2019/01/09
- Re: [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Paolo Bonzini, 2019/01/09
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99,
Eric Blake <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Paolo Bonzini, 2019/01/09
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Daniel P . Berrangé, 2019/01/10
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Greg Kurz, 2019/01/10
- Re: [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Thomas Huth, 2019/01/10
Re: [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99, Cédric Le Goater, 2019/01/09
[Qemu-ppc] [PATCH v3 2/2] configure: Force the C standard to gnu99, Thomas Huth, 2019/01/09
Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99, Richard Henderson, 2019/01/09