[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/3] machine: Eliminate unnecessary stringify() us
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-ppc] [PATCH 2/3] machine: Eliminate unnecessary stringify() usage |
Date: |
Tue, 8 Jan 2019 11:03:38 +0100 |
On Mon, 7 Jan 2019 17:30:19 -0200
Eduardo Habkost <address@hidden> wrote:
> stringify() is useful when we need to use macros in compat_props
> (like when we set virtio-baloon-pci.class=PCI_CLASS_MEMORY_RAM at
> pc_i440fx_1_0_machine_options()), but it is pointless when we are
> already providing a number literal.
>
> Replace stringify() with string literals when appropriate.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> hw/core/machine.c | 8 ++--
> hw/i386/pc.c | 94 +++++++++++++++++++++++------------------------
> hw/i386/pc_piix.c | 30 +++++++--------
> hw/ppc/spapr.c | 2 +-
> 4 files changed, 67 insertions(+), 67 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-ppc] [PATCH 0/3] machine: Make compat_props arrays shorter and more readable, Eduardo Habkost, 2019/01/07
- [Qemu-ppc] [PATCH 1/3] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro, Eduardo Habkost, 2019/01/07
- [Qemu-ppc] [PATCH 2/3] machine: Eliminate unnecessary stringify() usage, Eduardo Habkost, 2019/01/07
- [Qemu-ppc] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays, Eduardo Habkost, 2019/01/07
- Re: [Qemu-ppc] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays, Cornelia Huck, 2019/01/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays, Philippe Mathieu-Daudé, 2019/01/08