[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust

From: BALATON Zoltan
Subject: Re: [Qemu-ppc] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()
Date: Mon, 7 Jan 2019 23:00:55 +0100 (CET)
User-agent: Alpine 2.21.9999 (BSF 287 2018-06-16)

On Fri, 4 Jan 2019, David Gibson wrote:
On Thu, Jan 03, 2019 at 03:03:20PM +0100, BALATON Zoltan wrote:
On Wed, 2 Jan 2019, David Gibson wrote:
On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote:
To avoid overflow if larger values are added later use ram_addr_t for
the sdram_bank_sizes parameter to match ram_size to which it is

So, technically I think these should be 'hwaddr' (which represents a
guest physical address) rather tham ram_addr_t which
represents... something subtley different I've never properly

I don't understand the difference either but ram_size in MachineState where
this value comes from is ram_addr_t now so I've left is for now. If someone
knows which type should this be can change it in another patch

Ok, fair enough.

Then will you take v3 of this series or is there anything else that should be corrected?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]