[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v3 9/9] target/ppc: replace AVR* macros with Vsr*

From: Richard Henderson
Subject: Re: [Qemu-ppc] [PATCH v3 9/9] target/ppc: replace AVR* macros with Vsr* macros
Date: Thu, 20 Dec 2018 10:03:07 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/20/18 8:31 AM, Mark Cave-Ayland wrote:
> Now that the VMX and VSR register sets have been combined, the same macros can
> be used to access both AVR and VSR field members.
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/int_helper.c | 38 +++++++++++++-------------------------
>  target/ppc/internal.h   |  4 ++++
>  2 files changed, 17 insertions(+), 25 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

>  #if defined(HOST_WORDS_BIGENDIAN)
> +#define HI_IDX 0
> +#define LO_IDX 1
>  #define VsrB(i) u8[i]
>  #define VsrH(i) u16[i]
>  #define VsrW(i) u32[i]
>  #define VsrD(i) u64[i]

Since this is in internal.h, we can use it elsewhere than just helpers.  E.g.
if you sort some patches earlier, you could use it in get_avr64 instead of 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]