Re: [Qemu-ppc] [PATCH] target/ppc: fix compilation breakage on windows

[Peter Maydell]

On Mon, 17 Dec 2018 at 05:01, David Gibson <address@hidden> wrote:
>
> On Sat, Dec 15, 2018 at 07:42:22PM +0100, Cédric Le Goater wrote:

> > -#define PPC_BIT(bit)            (0x8000000000000000UL >> (bit))
> > -#define PPC_BIT32(bit)          (0x80000000UL >> (bit))
> > -#define PPC_BIT8(bit)           (0x80UL >> (bit))
> > +#define PPC_BIT(bit)            (0x8000000000000000ULL >> (bit))
> > +#define PPC_BIT32(bit)          (0x80000000ULL >> (bit))
> > +#define PPC_BIT8(bit)           (0x80ULL >> (bit))
>
> We shouldn't need the ULL for the 32-bit and (especially) 8-bit
> versions.

This is true, but I think "UL" is worth changing, as it's generally
not what you want, being a type that might be 32 or 64 bit.
Sensible suffix choices are "U", "ULL", or no suffix IMHO.

thanks
-- PMM