[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to E

From: Gerd Hoffmann
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to EDID data for the VGA device
Date: Wed, 12 Dec 2018 09:32:50 +0100
User-agent: NeoMutt/20180716

On Fri, Dec 07, 2018 at 04:08:05PM +0000, Mark Cave-Ayland wrote:
> This is in preparation for some upcoming QEMU NDRV driver changes that pass
> display information from the host to the guest.

> -    pci_vga_init(pci_bus);
> +    dev = qdev_create(BUS(pci_bus), "VGA");
> +    qdev_prop_set_int32(dev, "addr", -1);
> +    qdev_prop_set_bit(dev, "edid", true);
> +    qdev_init_nofail(dev);

Hmm.  IMO you should not overwrite the device defaults here.

edid is off by default only because it is new and I'm conservative.
I want a release (or two) with it being available for user testing.
If no issues pop up flip it to default on.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]