Re: [Qemu-ppc] [PATCH v5 10/36] spapr/xive: introduce a XIVE interrupt controller

[David Gibson]

On Tue, Dec 04, 2018 at 06:12:11PM +0100, Cédric Le Goater wrote:
> [ ... ]
> 
> >>> +void spapr_xive_pic_print_info(sPAPRXive *xive, Monitor *mon)
> >>> +{
> >>> +    int i;
> >>> +    uint32_t offset = 0;
> >>> +
> >>> +    monitor_printf(mon, "XIVE Source %08x .. %08x\n", offset,
> >>> +                   offset + xive->source.nr_irqs - 1);
> >>> +    xive_source_pic_print_info(&xive->source, offset, mon);
> >>> +
> >>> +    monitor_printf(mon, "XIVE EAT %08x .. %08x\n", 0, xive->nr_irqs - 1);
> >>> +    for (i = 0; i < xive->nr_irqs; i++) {
> >>> +        xive_eas_pic_print_info(&xive->eat[i], i, mon);
> >>> +    }
> >>> +
> >>> +    monitor_printf(mon, "XIVE ENDT %08x .. %08x\n", 0, xive->nr_ends - 
> >>> 1);
> >>> +    for (i = 0; i < xive->nr_ends; i++) {
> >>> +        xive_end_pic_print_info(&xive->endt[i], i, mon);
> >>> +    }
> >>
> >> AIUI the PAPR model hides the details of ENDs, EQs and NVTs - instead
> >> each logical EAS just points at a (thread, priority) pair, which under
> >> the hood has exactly one END and one NVT bound to it.
> >>
> >> Given that, would it make more sense to reformat the info here to show
> >> things in terms of those (thread, priority) pairs, rather than the
> >> internal EAS and END details?
> > 
> > Yes. I had a version doing something like that before. I will rework
> > the ouput a little for sPAPR.  
> 
> I would like to keep the 'advanced' monitor output in some ways and have
> two possible outputs : simple and long.
> 
> Is it possible to add command line options or arguments to the Monitor 
> interface ?

Not to the "info pic" command specifically, no.  Or at least, not
without a lot of work.

> 
> Thanks,
> 
> C. 
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature