Re: [Qemu-ppc] [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

[Thomas Huth]

On 2018-11-28 21:03, Eric Blake wrote:
> On 11/28/18 1:27 PM, BALATON Zoltan wrote:
>> Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and
>> bitbang_i2c.h an error even if they are identical. Move it to a common
>> place to allow building with this clang version.
>>
>> Reported-by: Thomas Huth <address@hidden>
>> Signed-off-by: BALATON Zoltan <address@hidden>
>> ---
>>   hw/i2c/bitbang_i2c.h        | 2 --
>>   include/hw/i2c/i2c.h        | 2 ++
>>   include/hw/i2c/ppc4xx_i2c.h | 3 ---
>>   3 files changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/hw/i2c/bitbang_i2c.h b/hw/i2c/bitbang_i2c.h
>> index 3a7126d5de..9443021710 100644
>> --- a/hw/i2c/bitbang_i2c.h
>> +++ b/hw/i2c/bitbang_i2c.h
>> @@ -3,8 +3,6 @@
>>     #include "hw/i2c/i2c.h"
>>   -typedef struct bitbang_i2c_interface bitbang_i2c_interface;
> 
> Would this also be an opportunity to rename the struct to something
> CamelCase to match our coding conventions?

That's a different issue, so I'd say it should be done in a different patch.

 Thomas