[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-ppc] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines |
|
Date: |
Tue, 27 Nov 2018 10:26:50 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 27/11/18 8:22, Thomas Huth wrote:
> On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote:
>> The CHRP NVRAM has his own section, but since the New World
>> section contains the mac_nvram.c, it makes sens to also monitor
>> the corresponding header.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 92691589b1..a248c8c564 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
>> F: include/hw/misc/macio/
>> F: include/hw/misc/mos6522.h
>> F: include/hw/ppc/mac_dbdma.h
>> +F: include/hw/nvram/chrp_nvram.h
>
> I don't see the point why we should add duplicated entries here? The
> header is also used by the Sparc machines, so why should this be added
> additionally to the Mac machines only here, too? I suggest to drop this
> patch.
OK, will drop.