[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v5 01/36] ppc/xive: introduce a XIVE interrupt sou

From: Cédric Le Goater
Subject: Re: [Qemu-ppc] [PATCH v5 01/36] ppc/xive: introduce a XIVE interrupt source model
Date: Mon, 26 Nov 2018 09:14:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

>>>> + */
>>>> +
>>>> +#ifndef PPC_XIVE_H
>>>> +#define PPC_XIVE_H
>>>> +
>>>> +#include "hw/sysbus.h"
>>> So, I'm a bit dubious about making the XiveSource a SysBus device -
>>> I'm concerned it won't play well with tying it into the other devices
>>> like PHB that "own" it in real hardware.
>> It does but I can take a look at changing it to a DeviceState. The 
>> reset handlers might be a concern.
> As "non bus" device I think you'd need to register your own reset
> handler rather than just setting dc->reset.  Otherwise, I think that
> should work.

I removed from XIVE the SysBus dependencies and indeed it's better 
not to rely on the default reset and mapping behavior of sysbus. 

I am addressing your comments in a WIP v6 branch on github.   


reply via email to

[Prev in Thread] Current Thread [Next in Thread]