[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 4/5] configs: Add a CONFIG_UNIMP switch for the "u
Re: [Qemu-ppc] [PATCH 4/5] configs: Add a CONFIG_UNIMP switch for the "unimplemented-device"
Fri, 19 Oct 2018 14:57:55 +0100
On 19 October 2018 at 14:14, Thomas Huth <address@hidden> wrote:
> The "unimplemented-device" is currently only used for one arm board.
? It's used in all the MPS boards, several of the imx SoCs,
the nrf51 SoC used by the microbit, and by the stellaris boards.
> Let's add a CONFIG switch to make sure that we only compile it when
> it is really necessary.
> Signed-off-by: Thomas Huth <address@hidden>
> default-configs/arm-softmmu.mak | 1 +
> hw/misc/Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 6f2ffc1..dc9730f 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -7,6 +7,7 @@ CONFIG_NAND=y
This seems awkward to me. The 'unimplemented' device is supposed
to be an entirely generic thing usable in any board model.
If we only turn it on in the arm-softmmu.mak then it means
faffing around with the default-configs/ whenever it gets
used in a different architecture.
In particular, there's a pull request on the list that uses
it in a sparc board, so this patch will break compile on sparc
once that pullreq lands.
[Qemu-ppc] [PATCH 5/5] configs: Add a CONFIG_SMC37C669 switch for the "smc37c669-superio" device, Thomas Huth, 2018/10/19