Re: [Qemu-ppc] [PATCH v3 09/22] memory-device: drop get_region_size()

[Igor Mammedov]

On Fri, 21 Sep 2018 09:19:17 +0200
David Hildenbrand <address@hidden> wrote:

> On 21/09/2018 07:19, David Gibson wrote:
> > On Thu, Sep 20, 2018 at 12:32:30PM +0200, David Hildenbrand wrote:  
> >> We now have get_memory_region(), which can be used generically to detect
> >> the region size. Use memory_device_get_region_size() where
> >> get_region_size() was used and use memory_device_get_region_size() as
> >> callback for get_plugged_size() (pc-dimm only for now).  
> > 
> > The commit message reads a little oddly.  I'm guessing it was written
> > before you split out the introduction of the
> > memory_device_get_region_size() wrapper into an earlier patch?  
> 
> Guess I changed it a couple of times while figuring out a way to do the
> transformations as cleanly as possible.
> 
> "There are no remaining users of get_region_size() except
> memory_device_get_region_size() itself. We can make
> memory_device_get_region_size() work directly on get_memory_region()
> instead and drop get_region_size().
> 
> In addition, we can now use memory_device_get_region_size() in pc-dimm
> code to implement get_plugged_size()".
Reviewed-by: Igor Mammedov <address@hidden>

> 
> Thanks!
> 
> >   
> >>
> >> Signed-off-by: David Hildenbrand <address@hidden>  
> > 
> > Nonetheless,
> > 
> > Reviewed-by: David Gibson <address@hidden>
> >   
> 
>