Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 0/2] 40p: fix PCI interrupt routing

[Mark Cave-Ayland]

On 19/09/2018 15:47, Roman Kapl wrote:

>>> Roman, can you reproduce this locally at all? My setup is nothing
>>> special, just Debian Stretch on amd64.
> 
> Ok, so I am able to reproduce it with your image and --enable-debug, but I 
> was not
> able to find the root cause, just narrow it.
> 
> It seems that the `dcbz` instruction is not emulated correctly (which may 
> lead to
> some garbage in inittab?). However, if I manualy inline the 
> `helper_dcbz_common` code
> into `helper dcbz`, it starts to work. I just literally copy it and add `int 
> mmu_idx
> = env->dmmu_idx;` at the beginning. That could be related to the 
> `--disable-debug`
> flag, since the compiler will inline the code when optimizations are enabled.
> 
> If you have any debugging ideas, they would be welcome. Maybe there are some 
> helper
> call limitations? Anyway, I will look at it again tomorrow.

Great, glad you managed to reproduce the issue. I'm not sure why the above 
would make
any difference at all, but I quickly tried your inline test above and that also
caused it to start to work for me? I'm still new at TCG so I'm not exactly sure 
what
to suggest right now - maybe someone else will have a better idea?

> Apart from that, I've found some problems in my EPID patch, I will send a fix
> shortly. Namely the instructions are enabled outside of Booke206, one 
> unrelated
> instruction had its opcode chcnaged by mistake and the slow path for dbczep 
> is wrong.
> However, these problems are not related to the problem with your image.

No worries.


ATB,

Mark.