[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* in
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-ppc] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)* |
|
Date: |
Fri, 15 Jun 2018 14:31:53 +0200 |
On Fri, 15 Jun 2018 13:52:25 +0200
David Hildenbrand <address@hidden> wrote:
> On 15.06.2018 13:51, Igor Mammedov wrote:
> > On Fri, 15 Jun 2018 13:24:50 +0200
> > David Hildenbrand <address@hidden> wrote:
> >
> >> Use a similar naming scheme as spapr. This way, we can go ahead and
> >> rename e.g. pc_dimm_memory_plug to pc_dimm_plug_plug, which avoids
> > ^^^^^ typo?
>
> Indeed, luckily only in the patch description.
with that fixed
Reviewed-by: Igor Mammedov <address@hidden>
- [Qemu-ppc] [PATCH v2 00/12] pc-dimm: next bunch of cleanups, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v2 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v2 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v2 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region(), David Hildenbrand, 2018/06/15