[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 0/4] coccinelle: re-run scripts from scripts/cocci
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-ppc] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle |
Date: |
Fri, 23 Mar 2018 15:37:24 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
22.03.2018 19:12, Laurent Vivier wrote:
> I've re-run some scripts from the coccinelle directory,
> and they have found some problems.
>
> This series fixes them.
>
> Laurent Vivier (4):
> error: Strip trailing '\n' from error string arguments (again again)
> error: Remove NULL checks on error_propagate() calls
> qdict: remove useless cast
> Remove unnecessary variables for function return value
I've applied patches 1-3, but the 4th patch is a bit.. interesting.
As has already been said, it touches auto-generated files, which is
sort of fine, but it _also_ removes comments, which - I think - is
quite a bit wrong.
I can apply just selected hunks, but.. hmm..
/mjt
- Re: [Qemu-ppc] [PATCH 4/4] Remove unnecessary variables for function return value, (continued)
- Re: [Qemu-ppc] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle,
Michael Tokarev <=