[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] target/ppc: Fix backwards migration of msr_mask
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [PATCH] target/ppc: Fix backwards migration of msr_mask |
Date: |
Tue, 20 Mar 2018 09:08:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 20/03/2018 03:23, David Gibson wrote:
> 21b786f "PowerPC: Add TS bits into msr_mask" added the transaction states
> to msr_mask for recent POWER CPUs to allow correct migration of machines
> that are in certain interim transactional memory states.
>
> This was correct, but unfortunately breaks backwards of pseries-2.7 and
> earlier machine types which (stupidly) transferred the msr_mask in the
> migration stream and failed if it wasn't equal on each end.
>
> This works around the problem by masking out the new MSR bits in the
> compatibility code to send the msr_mask on old machine types.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> target/ppc/machine.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Reviewed-by: Laurent Vivier <address@hidden>