[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PULL 0/9] ppc-for-2.12 queue 20180315
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [PULL 0/9] ppc-for-2.12 queue 20180315 |
Date: |
Sat, 17 Mar 2018 10:08:26 +0000 |
On 17 March 2018 at 04:02, David Gibson <address@hidden> wrote:
> On Fri, Mar 16, 2018 at 05:25:04PM +0000, Peter Maydell wrote:
>> Hi -- this looks like it provokes new runtime error warnings from the
>> clang sanitizer:
>
> Hrm. What options do you need to trip these warnings? Just using
> --cc=clang doesn't give them to me, and using --enable-sanitizers
> gives my piles of unrelated warnings.
https://wiki.qemu.org/Testing#clang_UBSan documents the necessary
cflags.
>
>>
>> TEST: tests/boot-serial-test... (pid=926)
>> /ppc/boot-serial/ppce500: OK
>> /ppc/boot-serial/prep: OK
>> /ppc/boot-serial/40p: OK
>> /ppc/boot-serial/g3beige: OK
>> /ppc/boot-serial/mac99: OK
>> /ppc/boot-serial/sam460ex:
>> /home/petmay01/linaro/qemu-for-merges/target/ppc/translate.c:2979:15:
>> runtime error: load of value 142, which is not a valid value for type
>> 'bool'
>> OK
>>
>> TEST: tests/boot-serial-test... (pid=1016)
>> /ppc64/boot-serial/ppce500: OK
>> /ppc64/boot-serial/prep: OK
>> /ppc64/boot-serial/40p: OK
>> /ppc64/boot-serial/mac99: OK
>> /ppc64/boot-serial/pseries: OK
>> /ppc64/boot-serial/powernv: OK
>> /ppc64/boot-serial/sam460ex:
>> /home/petmay01/linaro/qemu-for-merges/target/ppc/translate.c:2979:15:
>> runtime error: load of value 85, which is not a valid value for type
>> 'bool'
>> OK
>>
>> Looks like you're not initializing ctx->lazy_tlb_flush for all configs:
>> if (env->mmu_model == POWERPC_MMU_32B ||
>> env->mmu_model == POWERPC_MMU_601 ||
>> (env->mmu_model & POWERPC_MMU_64B))
>> ctx->lazy_tlb_flush = true;
>>
>> should perhaps be
>> ctx->lazy_tlb_flush =
>> env->mmu_model == POWERPC_MMU_32B ||
>> env->mmu_model == POWERPC_MMU_601 ||
>> (env->mmu_model & POWERPC_MMU_64B);
>>
>> ?
>
> Uh.. maybe.. except I don't see anything in the series that would be
> likely to change that behaviour.
I imagine it's "tests/boot-serial: Test the sam460ex board" --
this code was previously not being exercised in 'make check',
and now it is.
thanks
-- PMM
- [Qemu-ppc] [PULL 3/9] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices, (continued)
- [Qemu-ppc] [PULL 3/9] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices, David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 4/9] hw/misc/macio: Mark the macio devices with user_creatable = false, David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 1/9] sii3112: Remove unneeded exit function, David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 8/9] tests/boot-serial: Test the sam460ex board, David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 6/9] hw/ppc/spapr: Allow "spapr-vlan" as NIC model name beside "ibmveth", David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 5/9] PPC e500: Fix gap between u-boot and kernel, David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 9/9] target/ppc: fix tlbsync to check privilege level depending on GTSE, David Gibson, 2018/03/15
- [Qemu-ppc] [PULL 7/9] ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...), David Gibson, 2018/03/15
- Re: [Qemu-ppc] [PULL 0/9] ppc-for-2.12 queue 20180315, Peter Maydell, 2018/03/16
- Re: [Qemu-ppc] [PULL 0/9] ppc-for-2.12 queue 20180315, David Gibson, 2018/03/18