Re: [Qemu-ppc] [PATCH] target/ppc: fix tlbsync to check privilege level depending on GTSE

[Suraj Jitindar Singh]

On Wed, 2018-03-14 at 18:33 +0100, Cédric Le Goater wrote:
> tlbsync also needs to check the Guest Translation Shootdown Enable
> (GTSE) bit in the Logical Partition Control Register (LPCR) to
> determine at which privilege level it is running.
> 
> See commit c6fd28fd573d ("target/ppc: Update tlbie to check privilege
> level based on GTSE")
> 
> Signed-off-by: Cédric Le Goater <address@hidden>

Reviewed-by: Suraj Jitindar Singh <address@hidden>

> ---
> 
>  This will have its importance when we activate the HV bit on the
>  POWER9 CPU for the PowerNV machine.
> 
>  target/ppc/translate.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 0a0c090c9978..218665b4080b 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -4526,7 +4526,7 @@ static void gen_tlbie(DisasContext *ctx)
>      TCGv_i32 t1;
>  
>      if (ctx->gtse) {
> -        CHK_SV; /* If gtse is set then tblie is supervisor
> privileged */
> +        CHK_SV; /* If gtse is set then tlbie is supervisor
> privileged */

^^^ Did that line actually change? :)

>      } else {
>          CHK_HV; /* Else hypervisor privileged */
>      }
> @@ -4553,7 +4553,12 @@ static void gen_tlbsync(DisasContext *ctx)
>  #if defined(CONFIG_USER_ONLY)
>      GEN_PRIV;
>  #else
> -    CHK_HV;
> +
> +    if (ctx->gtse) {
> +        CHK_SV; /* If gtse is set then tlbsync is supervisor
> privileged */
> +    } else {
> +        CHK_HV; /* Else hypervisor privileged */
> +    }
>  
>      /* BookS does both ptesync and tlbsync make tlbsync a nop for
> server */
>      if (ctx->insns_flags & PPC_BOOKE) {