[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-arm] [Qemu-devel] [RFC PATCH v2 02/30] hw: include
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-ppc] [Qemu-arm] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h" |
|
Date: |
Mon, 5 Mar 2018 16:01:12 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/05/2018 03:57 PM, Daniel P. Berrangé wrote:
> On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daudé wrote:
>> These files were including "qemu/cutils.h" to use the byte-based size
>> definitions, now available in "qemu/cunits.h".
>
> I know I'm "complaining" about bike-shed colour here....
>
> Feels like just calling it units.h is sufficient - all our .h code is
> C code so don't need reminding of it by filename, particularly since
> we're avoiding system header clash by using the qemu/ prefix on #includes.
I like your suggestion :)
>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> Regardless of whether you rename it or not though,
>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
Thanks!
>
>
> Regards,
> Daniel
>