Re: [Qemu-ppc] [Qemu-devel] [PATCH 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"

[Philippe Mathieu-Daudé]

Hi Thomas,

On 02/15/2018 03:10 AM, Thomas Huth wrote:
> On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote:
>> These files were including "qemu/cutils.h" to use the byte-based size
>> definitions, now available in "qemu/cunits.h".
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>  include/hw/hw.h       | 1 +
>>  hw/arm/msf2-soc.c     | 1 -
>>  hw/arm/msf2-som.c     | 1 -
>>  hw/core/loader-fit.c  | 1 -
>>  hw/core/loader.c      | 1 -
>>  hw/core/machine.c     | 1 -
>>  hw/cris/boot.c        | 1 -
>>  hw/display/sm501.c    | 1 -
>>  hw/hppa/machine.c     | 1 -
>>  hw/lm32/milkymist.c   | 1 -
>>  hw/microblaze/boot.c  | 1 -
>>  hw/mips/boston.c      | 1 -
>>  hw/misc/mos6522.c     | 1 -
>>  hw/nios2/boot.c       | 1 -
>>  hw/ppc/mac_newworld.c | 1 -
>>  hw/ppc/mac_oldworld.c | 1 -
>>  hw/ppc/pnv.c          | 1 -
>>  hw/ppc/prep.c         | 1 -
>>  hw/ppc/spapr_rtas.c   | 1 -
>>  hw/sd/sdhci.c         | 1 -
>>  hw/sparc/sun4m.c      | 1 -
>>  hw/sparc64/sun4u.c    | 1 -
>>  hw/usb/dev-serial.c   | 1 -
>>  hw/usb/dev-storage.c  | 1 -
>>  24 files changed, 1 insertion(+), 23 deletions(-)
>>
>> diff --git a/include/hw/hw.h b/include/hw/hw.h
>> index ab4950c312..8249448cac 100644
>> --- a/include/hw/hw.h
>> +++ b/include/hw/hw.h
>> @@ -14,6 +14,7 @@
>>  #include "migration/qemu-file-types.h"
>>  #include "qemu/module.h"
>>  #include "sysemu/reset.h"
>> +#include "qemu/cunits.h"
> 
> Instead of adding this to a header and creating yet another possible
> recompile-the-world dependency this way, wouldn't it be better to
> include the cunits.h only from the .c files that need the definitions?

I was waiting for other opinions but I can change if you prefer;
meanwhile I'll respin this patch as RFC.

Regards,

Phil.