[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 1/3] translator: add retcode to translator_loop_te
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-ppc] [PATCH 1/3] translator: add retcode to translator_loop_temp_check |
Date: |
Thu, 15 Feb 2018 11:24:02 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Feb 15, 2018 at 07:09:56 -0800, Richard Henderson wrote:
> On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> > -void translator_loop_temp_check(DisasContextBase *db);
> > +int translator_loop_temp_check(DisasContextBase *db);
>
> bool.
>
> Although I don't see how this is helpful. If you want to customize the
> output,
> surely you just use tcg_check_temp_count directly?
The only advantage is that we get to keep the same warning on
all targets [that support the temps' check]. Admittedly
not a huge benefit; I can drop this if you want.
Thanks,
E.