Re: [Qemu-ppc] [Qemu-devel] fix evsrwu and others for powerpcspe

[Richard Henderson]

On 02/09/2018 11:25 PM, Michael Tokarev wrote:
> 26.12.2017 14:29, address@hidden wrote:
>> GEN_SPEOP_ARITH2 declares non-local temporaries then calls 
>> gen_op_evsrwu/evsrws/evslw which generates branch insn.
> 
> I'm Cc'ing qemu-devel@ for review, since I don't know much about how ppc 
> works.
> 
> Thanks,
> 
> /mjt
> 
>> --- target/ppc/translate/spe-impl.inc.c.orig
>> +++ target/ppc/translate/spe-impl.inc.c
>> @@ -158,8 +158,8 @@
>>          gen_exception(ctx, POWERPC_EXCP_SPEU);                              
>>   \
>>          return;                                                             
>>   \
>>      }                                                                       
>>   \
>> -    t0 = tcg_temp_new_i32();                                                
>>   \
>> -    t1 = tcg_temp_new_i32();                                                
>>   \
>> +    t0 = tcg_temp_local_new_i32();                                          
>>         \
>> +    t1 = tcg_temp_local_new_i32();                                          
>>         \

While that's one possible solution, it would be better to rewrite the helpers
not to use branches.  E.g.

    tcg_gen_andi_i32(t0, arg2, 0x1f);
    tcg_gen_andi_i32(t1, arg2, 0x20);
    tcg_gen_shr_i32(ret, arg1, t0);
    tcg_gen_movi_i32(t0, 0);
    tcg_gen_movcond_i32(TCG_COND_NE, ret, t1, t0, t0, ret);


r~