[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] spapr_pci: use warn_report()
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH] spapr_pci: use warn_report() |
Date: |
Tue, 19 Dec 2017 11:38:05 +1100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Dec 18, 2017 at 04:58:02PM +0100, Greg Kurz wrote:
> These two are definitely warnings. Let's use the appropriate API.
>
> Signed-off-by: Greg Kurz <address@hidden>
Applied to ppc-for-2.12, thanks.
> ---
> hw/ppc/spapr_pci.c | 6 +++---
> hw/ppc/spapr_pci_vfio.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 88797b3d3622..695c82091140 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1696,9 +1696,9 @@ static void spapr_phb_realize(DeviceState *dev, Error
> **errp)
> /* DMA setup */
> if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
> && kvm_enabled()) {
> - error_report("System page size 0x%lx is not enabled in
> page_size_mask "
> - "(0x%"PRIx64"). Performance may be slow",
> - qemu_getrampagesize(), sphb->page_size_mask);
> + warn_report("System page size 0x%lx is not enabled in page_size_mask
> "
> + "(0x%"PRIx64"). Performance may be slow",
> + qemu_getrampagesize(), sphb->page_size_mask);
> }
>
> for (i = 0; i < windows_supported; ++i) {
> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> index 8448e0b0247d..1f775ea93dc6 100644
> --- a/hw/ppc/spapr_pci_vfio.c
> +++ b/hw/ppc/spapr_pci_vfio.c
> @@ -50,7 +50,7 @@ static Property spapr_phb_vfio_properties[] = {
> static void spapr_phb_vfio_instance_init(Object *obj)
> {
> if (!qtest_enabled()) {
> - error_report("spapr-pci-vfio-host-bridge is deprecated");
> + warn_report("spapr-pci-vfio-host-bridge is deprecated");
> }
> }
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature