[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 18/24] fixup! ppc: spapr: use gene
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 18/24] fixup! ppc: spapr: use generic cpu_model parsing |
Date: |
Mon, 23 Oct 2017 15:43:41 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 13/10/17 09:24, David Gibson wrote:
> On Thu, Oct 12, 2017 at 05:50:08PM +0200, Igor Mammedov wrote:
>> inot sure how it managed to compile locally and on travis
>
> Because target/ppc/kvm.c is only compiled on a ppc _host_.
that or in cross environment, to be precise.
>
>> but build fails with type mismatch on PPC host, fixup it
>> by casting to expected type
>
> I already hit this one and fixed it up in place.
>
>>
>> Signed-off-by: Igor Mammedov <address@hidden>
>> ---
>> target/ppc/kvm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
>> index 48dc3f7..9d57deb 100644
>> --- a/target/ppc/kvm.c
>> +++ b/target/ppc/kvm.c
>> @@ -2505,7 +2505,7 @@ static int kvm_ppc_register_host_cpu_type(MachineState
>> *ms)
>> }
>> type_info.parent = object_class_get_name(OBJECT_CLASS(pvr_pcc));
>> type_register(&type_info);
>> - if (object_dynamic_cast(ms, TYPE_SPAPR_MACHINE)) {
>> + if (object_dynamic_cast(OBJECT(ms), TYPE_SPAPR_MACHINE)) {
>> /* override TCG default cpu type with 'host' cpu model */
>> mc->default_cpu_type = TYPE_HOST_POWERPC_CPU;
>> }
>
--
Alexey
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH v2 16/24] ppc: spapr: use cpu model names as tcg defaults instead of aliases, (continued)
- [Qemu-ppc] [PATCH v2 20/24] ppc: pnv: normalize core/chip type names, Igor Mammedov, 2017/10/09
- [Qemu-ppc] [PATCH v2 22/24] ppc: pnv: define core types statically, Igor Mammedov, 2017/10/09
- [Qemu-ppc] [PATCH v2 21/24] ppc: pnv: drop PnvCoreClass::cpu_oc field, Igor Mammedov, 2017/10/09
- [Qemu-ppc] [PATCH v2 24/24] ppc: pnv: consolidate type definitions and batch register them, Igor Mammedov, 2017/10/09
- [Qemu-ppc] [PATCH v2 23/24] ppc: pnv: drop PnvChipClass::cpu_model field, Igor Mammedov, 2017/10/09
- Re: [Qemu-ppc] [PATCH v2 00/24] generalize parsing of cpu_model (part 3/PPC), David Gibson, 2017/10/09