Re: [Qemu-ppc] [RFC PATCH v2 18/21] ppc/xive: add device tree support

[Cédric Le Goater]

On 09/28/2017 10:43 AM, Benjamin Herrenschmidt wrote:
> On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote:
>> Let me be more precise. I am saying that the interrupt-controller 
>> and #interrupt-cells properties are not needed under the main interrupt 
>> controller node. They can be removed from the tree and the Linux guest 
>> kernel will boot perfectly well.
> 
> No they are needed. They are the parents of PCI interrupts for example.
> There's something fishy here.

probably, I just removed the properties under QEMU and could 
boot the guest, with disks and network.

 
> Do you have a DT snapshot from pHyp for me to look at ?


# lsprop /proc/device-tree/address@hidden/
compatible       "ibm,power-ivpe"
device_type      "power-ivpe"
ibm,xive-eq-sizes
                 00000007 00000009 0000000c 0000000e
                 00000010 00000012 00000015 00000016
                 00000018
reg              00000002 00010000 00000000 00010000
                 00000002 00000000 00000000 00010000
linux,phandle    00dce438 (14476344)
ibm,xive-lisn-ranges
                 00094000 00000030
name             "interrupt-controller"


Cheers,

C. 

> 
>> These properties still are needed under the sub nodes like :
>>
>> /proc/device-tree/vdevice/interrupt-controller
>> /proc/device-tree/event-sources/interrupt-controller