Re: [Qemu-ppc] [PATCH 7/8] openpic: add missing timer fields to vmstate_openpic_timer

[Mark Cave-Ayland]

On 18/09/17 23:44, David Gibson wrote:

> So, adding new things to the migration stream always requires some
> thought.  The commit message should contain a rationale for why the
> proposed representation is a good one.  In particular is it one that's
> unlikely to be difficult if the device changes internal details in
> future.  When possible it's best to stick to architected documented
> state of the modelled hardware, though I can see you're probably going
> to need some extras in this case.

Yes, I think that's the case here. Definitely the timer can't be armed
correctly without origin_time, and if qemu_timer_active isn't present
and migration occurs with an active timer then a subsequent call to
openpic_tmr_get_timer() will be incorrect. Does that sound right to you?


ATB,

Mark.