[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 14/15] ppc4xx: Add device models found in PPC440 c
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 14/15] ppc4xx: Add device models found in PPC440 core SoCs |
Date: |
Wed, 23 Aug 2017 12:49:43 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote:
> These devices are found in newer SoCs based on 440 core e.g. the 460EX
> (http://www.embeddeddeveloper.com/assets/processors/amcc/datasheets/
> PP460EX_DS2063.pdf)
As usual, I can't review in depth, but there's not much obviously
bogus, so I'm inclined to merge, except for one detail:
[snip]
> +#ifdef MAP_L2SRAM
> +static void l2sram_update_mappings(ppc4xx_l2sram_t *l2sram,
> + uint32_t isarc, uint32_t isacntl,
> + uint32_t dsarc, uint32_t dsacntl)
> +{
> +#ifdef DEBUG_L2SRAM
> + printf("L2SRAM update ISA %08" PRIx32 " %08" PRIx32 " (%08" PRIx32
> + " %08" PRIx32 ") DSA %08" PRIx32 " %08" PRIx32
> + " (%08" PRIx32 " %08" PRIx32 ")\n",
> + isarc, isacntl, dsarc, dsacntl,
> + l2sram->isarc, l2sram->isacntl, l2sram->dsarc, l2sram->dsacntl);
For new code, trace points are strongly preferred to DPRINTF() macros
or explicit printf()s. In addition sending this output to stdout
rather than stderr is a pretty bad idea.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, (continued)
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/23
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/24
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/24
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/23
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/24
- Re: [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/24
[Qemu-ppc] [PATCH 14/15] ppc4xx: Add device models found in PPC440 core SoCs, BALATON Zoltan, 2017/08/20
- Re: [Qemu-ppc] [PATCH 14/15] ppc4xx: Add device models found in PPC440 core SoCs,
David Gibson <=
Re: [Qemu-ppc] [PATCH 00/15] Sam460ex emulation, BALATON Zoltan, 2017/08/27
Re: [Qemu-ppc] [PATCH 00/15] Sam460ex emulation, David Gibson, 2017/08/29