[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time
From: |
Greg Kurz |
Subject: |
Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time |
Date: |
Thu, 8 Jun 2017 10:54:02 +0200 |
On Thu, 8 Jun 2017 07:50:08 +0200
Cédric Le Goater <address@hidden> wrote:
> On 06/07/2017 10:55 PM, Greg Kurz wrote:
> [...]
> >>> + obj = object_new(TYPE_PNV_ICP);
> >>> + object_property_add_child(child, "icp", obj, NULL);
> >>> + object_unref(obj);
> >>> + object_property_add_const_link(obj, "xics", OBJECT(xi),
> >>> &error_abort);
> >>> + object_property_add_const_link(obj, "cs", child, &error_abort);
> >>
> >> may be link the cpu object instead ?
> >>
> >
> > I'm not sure to understand... isn't child supposed to be a CPU index here ?
> >
>
> I meant linking the 'PowerPCCPU *cpu' object and not the CPUState.
> That's minor.
>
Well, cpu == cs == child and object_property_add_const_link() expects
an Object *. Passing child avoids a not-really-useful OBJECT() dynamic
cast.
pgpNshXbBrtYA.pgp
Description: OpenPGP digital signature
- Re: [Qemu-ppc] [PATCH v3 2/5] xics: add reset() handler to ICPStateClass, (continued)
- [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Cédric Le Goater, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, David Gibson, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Cédric Le Goater, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Cédric Le Goater, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time,
Greg Kurz <=
Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, David Gibson, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Cédric Le Goater, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, David Gibson, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/09
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, David Gibson, 2017/06/09
[Qemu-ppc] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate, Greg Kurz, 2017/06/07