qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] hw/pci-host/prep: Do not use hw_error() in realiz


From: Hervé Poussineau
Subject: Re: [Qemu-ppc] [PATCH] hw/pci-host/prep: Do not use hw_error() in realize function
Date: Fri, 10 Feb 2017 00:10:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0

Le 09/02/2017 à 12:14, Thomas Huth a écrit :
hw_error() is for CPU related errors only (it prints out a
register dump and calls abort()), so we should not use it
if we just failed to load the bios image. Apart from that,
realize() functions should not exit directly but always set
the errp with error_setg() in case of errors instead.
Additionally, move some code around and delete the bios memory
subregion again in case of such an error, so that we leave a
clean state when returning to the caller.

Signed-off-by: Thomas Huth <address@hidden>
---
 hw/pci-host/prep.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)


Reviewed-by: Hervé Poussineau <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]