Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH v2 0/2] softfloat: Add round-to-odd rounding mode

[Bharata B Rao]

On Fri, Jan 27, 2017 at 12:09:13AM -0800, address@hidden wrote:
> Hi,
> 
> Your series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Subject: [Qemu-devel] [RFC PATCH v2 0/2] softfloat: Add round-to-odd rounding 
> mode
> Message-id: address@hidden
> 
> Checking PATCH 1/2: softfloat: Handle float64 rounding properly for underflow 
> case...
> Checking PATCH 2/2: softfloat: Add round-to-odd rounding mode...
> ERROR: space prohibited after that '-' (ctx:WxW)
> #41: FILE: fpu/softfloat.c:641:
> +            return packFloat64( zSign, 0x7FF, - ( !overflow_to_inf ));
>                                                ^
> 
> ERROR: space prohibited after that open parenthesis '('
> #41: FILE: fpu/softfloat.c:641:
> +            return packFloat64( zSign, 0x7FF, - ( !overflow_to_inf ));
> 
> ERROR: space prohibited before that close parenthesis ')'
> #41: FILE: fpu/softfloat.c:641:
> +            return packFloat64( zSign, 0x7FF, - ( !overflow_to_inf ));
> 
> ERROR: space prohibited after that open parenthesis '('
> #69: FILE: fpu/softfloat.c:1199:
> +                 || ( roundingMode == float_round_to_odd )
> 
> ERROR: space prohibited before that close parenthesis ')'
> #69: FILE: fpu/softfloat.c:1199:
> +                 || ( roundingMode == float_round_to_odd )
> 
> total: 5 errors, 0 warnings, 62 lines checked

fpu/softfloat.c follows a different coding style and hence it made
sense to stick to the existing style in the file.

Regards,
Bharata.