Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH v2 0/2] softfloat: Add round-to-odd rounding mode

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC PATCH v2 0/2] softfloat: Add round-to-odd rounding 
mode
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3adbab9 softfloat: Add round-to-odd rounding mode
afe7f83 softfloat: Handle float64 rounding properly for underflow case

=== OUTPUT BEGIN ===
Checking PATCH 1/2: softfloat: Handle float64 rounding properly for underflow 
case...
Checking PATCH 2/2: softfloat: Add round-to-odd rounding mode...
ERROR: space prohibited after that '-' (ctx:WxW)
#41: FILE: fpu/softfloat.c:641:
+            return packFloat64( zSign, 0x7FF, - ( !overflow_to_inf ));
                                               ^

ERROR: space prohibited after that open parenthesis '('
#41: FILE: fpu/softfloat.c:641:
+            return packFloat64( zSign, 0x7FF, - ( !overflow_to_inf ));

ERROR: space prohibited before that close parenthesis ')'
#41: FILE: fpu/softfloat.c:641:
+            return packFloat64( zSign, 0x7FF, - ( !overflow_to_inf ));

ERROR: space prohibited after that open parenthesis '('
#69: FILE: fpu/softfloat.c:1199:
+                 || ( roundingMode == float_round_to_odd )

ERROR: space prohibited before that close parenthesis ')'
#69: FILE: fpu/softfloat.c:1199:
+                 || ( roundingMode == float_round_to_odd )

total: 5 errors, 0 warnings, 62 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden