[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle |
Date: |
Tue, 22 Nov 2016 13:50:04 +1100 |
On Tue, 2016-11-22 at 02:34 +0100, BALATON Zoltan wrote:
> > Is this going in for 2.8? If so, I'll need to apply the corresponding
> > patch to OpenBIOS to match and also do a PPC testing cycle to make sure
> > that there are no regressions on other OSs. Plus it would be useful to
> > get both pull requests in close proximity as this will break bisection.
>
> (Adding BenH as these are his patches I just apparently forgot the cc.)
>
> I'd appreciate if this could get in 2.8. As this is a bugfix this should
> be OK during the freeze. Likely there will be more rc cycles where it
> could be reverted if found to cause problems. But since it's already
> broken, applying this patch to QEMU should not break it more and adding
> the fix on the OpenBIOS side (patch 4/4) would complete the fix and may
> actually make it work. This should only affect mac99 and this one patch is
> independent from the other three I've sent to OpenBIOS so this could be
> applied independently to get at least the interrupts fixed if you can't
> test and apply the other three until the next pull.
Right, PCI IRQs are terminally broken already. This patch without the
OpenBIOS change won't hurt. With the OpenBIOS change, things start
working better :-)
I appologize for being basically MIA these days, way too busy with
other things. Feel free to pick up ownership of my patches if you
want to get them into upstreamable state, such as the SunGEM one.
I don't know if I'll have any bandwidth to work on that stuff again
until later next year.
Cheers,
Ben.