[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [QEMU PATCH v7 2/3] migration: migrate QTAIL
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [QEMU PATCH v7 2/3] migration: migrate QTAILQ |
|
Date: |
Thu, 27 Oct 2016 14:01:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 26/10/2016 18:58, Jianjun Duan wrote:
>> >
>> > Seems you partially adopted Paolo's suggestion for improving the
>> > macros. Is there a particular reason why you did not follow it more
>> > closely? I find the solution with field_at_offset(base, offset, type)
>> > more readable than with RAW_FIELD(base, offset).
>> >
> field_at_offset is too general. We only use (void **) and (void ***)
> here.
Uhm, field_at_offset is exactly the same as RAW_FIELD. :)
Paolo
[Qemu-ppc] [QEMU PATCH v7 3/3] tests/migration: Add test for QTAILQ migration, Jianjun Duan, 2016/10/21
Re: [Qemu-ppc] [Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ, no-reply, 2016/10/21