[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCHv5 05/12] tests: Adjust tco-test to use qpci_legacy
From: |
Greg Kurz |
Subject: |
Re: [Qemu-ppc] [PATCHv5 05/12] tests: Adjust tco-test to use qpci_legacy_iomap() |
Date: |
Tue, 25 Oct 2016 14:35:20 +0200 |
On Mon, 24 Oct 2016 15:59:54 +1100
David Gibson <address@hidden> wrote:
> Avoid tco-test making assumptions about the internal format of the address
> tokens passed to PCI IO accessors, by using the new qpci_legacy_iomap()
> function.
>
> Signed-off-by: David Gibson <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> tests/tco-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tco-test.c b/tests/tco-test.c
> index 0d201b1..129577d 100644
> --- a/tests/tco-test.c
> +++ b/tests/tco-test.c
> @@ -70,7 +70,7 @@ static void test_init(TestData *d)
> /* set Root Complex BAR */
> qpci_config_writel(d->dev, ICH9_LPC_RCBA, RCBA_BASE_ADDR | 0x1);
>
> - d->tco_io_base = (void *)((uintptr_t)PM_IO_BASE_ADDR + 0x60);
> + d->tco_io_base = qpci_legacy_iomap(d->dev, PM_IO_BASE_ADDR + 0x60);
> }
>
> static void stop_tco(const TestData *d)
- [Qemu-ppc] [PATCHv5 00/12] Cleanups to qtest PCI handling, David Gibson, 2016/10/24
- [Qemu-ppc] [PATCHv5 04/12] libqos: Better handling of PCI legacy IO, David Gibson, 2016/10/24
- [Qemu-ppc] [PATCHv5 05/12] tests: Adjust tco-test to use qpci_legacy_iomap(), David Gibson, 2016/10/24
- Re: [Qemu-ppc] [PATCHv5 05/12] tests: Adjust tco-test to use qpci_legacy_iomap(),
Greg Kurz <=
- [Qemu-ppc] [PATCHv5 11/12] tests: Don't assume structure of PCI IO base in ahci-test, David Gibson, 2016/10/24
- [Qemu-ppc] [PATCHv5 01/12] libqos: Give qvirtio_config_read*() consistent semantics, David Gibson, 2016/10/24
- [Qemu-ppc] [PATCHv5 10/12] tests: Use qpci_mem{read, write} in ivshmem-test, David Gibson, 2016/10/24
- [Qemu-ppc] [PATCHv5 07/12] libqos: Implement mmio accessors in terms of mem{read, write}, David Gibson, 2016/10/24