Re: [Qemu-ppc] [PATCH 2/3] ppc: allow system reset interrupt to be delivered to guests

[Cédric Le Goater]

On 10/20/2016 08:59 AM, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <address@hidden>
> ---
>  target-ppc/excp_helper.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c
> index 53c4075..477af10 100644
> --- a/target-ppc/excp_helper.c
> +++ b/target-ppc/excp_helper.c
> @@ -390,9 +390,13 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int 
> excp_model, int excp)
>              /* indicate that we resumed from power save mode */
>              msr |= 0x10000;
>              new_msr |= ((target_ulong)1 << MSR_ME);
> +            new_msr |= (target_ulong)MSR_HVB;
> +        } else {
> +         /* The ISA specifies the HV bit is set when the hardware interrupt
> +          * is raised, however when hypervisors deliver the exception to
> +          * guests, it should not be set.
> +          */
>          }
> -
> -        new_msr |= (target_ulong)MSR_HVB;
>          ail = 0;
>          break;
>      case POWERPC_EXCP_DSEG:      /* Data segment exception                   
> */
> 

should not that be cleared later on in powerpc_excp() by :

    env->msr = new_msr & env->msr_mask;

? but the routine is rather long so I might be missing a branch.

C.