Re: [Qemu-ppc] [PATCH 01/13] pseries: Remove unused callbacks from sPAPR VIO bus state

[Thomas Huth]

On 20.10.2016 07:11, David Gibson wrote:
> The original QOMification of the spapr VIO devices in 3954d33 "spapr:
> convert to QEMU Object Model (v2)" moved some callbacks from the
> VIOsPAPRBus structure to the VIOsPAPRDeviceClass.  Except, that it
> forgot to actually remove them from the VIOsPAPRBus structure (which
> still exists, though it doesn't fulfill quite the same function as it
> did pre-QOM).
> 
> This patch removes those now unused callback fields.
> 
> Signed-off-by: David Gibson <address@hidden>
> Reviewed-by: Alexey Kardashevskiy <address@hidden>
> ---
>  include/hw/ppc/spapr_vio.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h
> index 40d0e5f..0b025fd 100644
> --- a/include/hw/ppc/spapr_vio.h
> +++ b/include/hw/ppc/spapr_vio.h
> @@ -76,8 +76,6 @@ struct VIOsPAPRDevice {
>  struct VIOsPAPRBus {
>      BusState bus;
>      uint32_t next_reg;
> -    int (*init)(VIOsPAPRDevice *dev);
> -    int (*devnode)(VIOsPAPRDevice *dev, void *fdt, int node_off);
>  };
>  
>  extern VIOsPAPRBus *spapr_vio_bus_init(void);
> 

Reviewed-by: Thomas Huth <address@hidden>