[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCHv2 05/11] tests: Adjust tco-test to use qpci_legacy
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [PATCHv2 05/11] tests: Adjust tco-test to use qpci_legacy_iomap() |
Date: |
Wed, 19 Oct 2016 15:35:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 19/10/2016 14:25, David Gibson wrote:
> Avoid tco-test making assumptions about the internal format of the address
> tokens passed to PCI IO accessors, by using the new qpci_legacy_iomap()
> function.
>
> Signed-off-by: David Gibson <address@hidden>
I think you should merge it with the previous one...
Anyway:
Reviewed-by: Laurent Vivier <address@hidden>
> ---
> tests/tco-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tco-test.c b/tests/tco-test.c
> index 0d201b1..129577d 100644
> --- a/tests/tco-test.c
> +++ b/tests/tco-test.c
> @@ -70,7 +70,7 @@ static void test_init(TestData *d)
> /* set Root Complex BAR */
> qpci_config_writel(d->dev, ICH9_LPC_RCBA, RCBA_BASE_ADDR | 0x1);
>
> - d->tco_io_base = (void *)((uintptr_t)PM_IO_BASE_ADDR + 0x60);
> + d->tco_io_base = qpci_legacy_iomap(d->dev, PM_IO_BASE_ADDR + 0x60);
> }
>
> static void stop_tco(const TestData *d)
>
- [Qemu-ppc] [PATCHv2 00/11] Cleanups to qtest PCI handling, David Gibson, 2016/10/19
- [Qemu-ppc] [PATCHv2 05/11] tests: Adjust tco-test to use qpci_legacy_iomap(), David Gibson, 2016/10/19
- Re: [Qemu-ppc] [PATCHv2 05/11] tests: Adjust tco-test to use qpci_legacy_iomap(),
Laurent Vivier <=
- [Qemu-ppc] [PATCHv2 04/11] libqos: Better handling of PCI legacy IO, David Gibson, 2016/10/19
- [Qemu-ppc] [PATCHv2 02/11] libqos: Handle PCI IO de-multiplexing in common code, David Gibson, 2016/10/19
- [Qemu-ppc] [PATCHv2 06/11] libqos: Add streaming accessors for PCI MMIO, David Gibson, 2016/10/19
- [Qemu-ppc] [PATCHv2 10/11] tests: Use qpci_mem{read, write} in ivshmem-test, David Gibson, 2016/10/19
- [Qemu-ppc] [PATCHv2 07/11] libqos: Implement mmio accessors in terms of mem{read, write}, David Gibson, 2016/10/19