Re: [Qemu-ppc] [PATCH v5 0/6] tests: enable virtio tests on SPAPR

[David Gibson]

On Mon, Oct 17, 2016 at 12:30:18PM +0200, Laurent Vivier wrote:
> This series enables virtio tests on SPAPR by starting
> machines using qtest_pc_boot() or qtest_spapr_boot() to
> use the good libqos PCI framework (pc or spapr).
> 
> It adds also some byte-swapping in virtio-pci.c as
> PCI is always little-endian and the endianness of
> the virtio device depends on the endianness of the
> guest.
> 
> This series does not enable virtio PCI MSI-X tests on
> SPAPR as this needs more work and will be the aim
> of another series.

Looking good to me.  I've tentatively merged this to ppc-for-2.8,
unless someone thinks it doesn't belong there.

> 
> v5:
> - minor updates:
>   - remove declaration within the code
>   - update comment about qtest_vboot()
>     (terminates on failure)
> v4:
> - rebase on papr/ppc-for-2.8
> - add a patch to rename target_big_endian() to qvirtio_is_big_endian()
> - Add a patch to remove the QVirtioBus arguments from all virtio functions
> 
> v3:
> - remove "ppc" from allowed archs for virtio-blk-test
> - remove g_assert_nonnull() after g_malloc()
> - add a patch to fix "vs" memory leak in virtio-scsi-test
> - add a patch to remove g_assert() after qtest_spapr_boot()
>   and update comment qtest_vboot() to explain it never
>   returns NULL.
> 
> v2:
> - update comments (virtio-1.0, log)
> - move g_assert_nonnull() to qtest_boot()
> - exit gracefully if the architecture is not supported
> - replace qtest_pc_shutdown() by qtest_shutdown()
> - move qvirtio_scsi_stop() to qvirtio_scsi_pci_free()
> 
> Laurent Vivier (6):
>   tests: fix memory leak in virtio-scsi-test
>   tests: don't check if qtest_spapr_boot() returns NULL
>   tests: move QVirtioBus pointer into QVirtioDevice
>   tests: rename target_big_endian() as qvirtio_is_big_endian()
>   tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests
>   tests: enable virtio tests on SPAPR
> 
>  tests/Makefile.include     |   3 +-
>  tests/libqos/libqos.c      |   2 +
>  tests/libqos/virtio-mmio.c |   1 +
>  tests/libqos/virtio-pci.c  |  28 +++-
>  tests/libqos/virtio.c      |  77 +++++------
>  tests/libqos/virtio.h      |  57 ++++----
>  tests/libqtest.h           |  10 --
>  tests/rtas-test.c          |   1 -
>  tests/vhost-user-test.c    |  33 +++--
>  tests/virtio-9p-test.c     |  69 +++++-----
>  tests/virtio-blk-test.c    | 322 
> +++++++++++++++++++++------------------------
>  tests/virtio-net-test.c    | 106 +++++++--------
>  tests/virtio-rng-test.c    |   7 +-
>  tests/virtio-scsi-test.c   |  91 ++++++-------
>  14 files changed, 400 insertions(+), 407 deletions(-)
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature