[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() retur
From: |
Laurent Vivier |
Subject: |
[Qemu-ppc] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() returns NULL |
Date: |
Fri, 14 Oct 2016 10:58:51 +0200 |
qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot()
and qtest_vboot() calls g_malloc(),
and g_malloc() never fails:
if memory allocation fails, the application is terminated.
Signed-off-by: Laurent Vivier <address@hidden>
---
tests/libqos/libqos.c | 1 +
tests/rtas-test.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c
index 7abb482..65d6296 100644
--- a/tests/libqos/libqos.c
+++ b/tests/libqos/libqos.c
@@ -10,6 +10,7 @@
/**
* Launch QEMU with the given command line,
* and then set up interrupts and our guest malloc interface.
+ * Never return NULL as the application is terminated if g_malloc() fails.
*/
QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap)
{
diff --git a/tests/rtas-test.c b/tests/rtas-test.c
index ba0867a..276c87e 100644
--- a/tests/rtas-test.c
+++ b/tests/rtas-test.c
@@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void)
time_t t1, t2;
qs = qtest_spapr_boot("-machine pseries");
- g_assert(qs != NULL);
t1 = time(NULL);
ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns);
--
2.7.4
- [Qemu-ppc] [PATCH v4 0/6] tests: enable virtio tests on SPAPR, Laurent Vivier, 2016/10/14
- [Qemu-ppc] [PATCH v4 1/6] tests: fix memory leak in virtio-scsi-test, Laurent Vivier, 2016/10/14
- [Qemu-ppc] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() returns NULL,
Laurent Vivier <=
- [Qemu-ppc] [PATCH v4 4/6] tests: rename target_big_endian() as qvirtio_is_big_endian(), Laurent Vivier, 2016/10/14
- [Qemu-ppc] [PATCH v4 5/6] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests, Laurent Vivier, 2016/10/14
- [Qemu-ppc] [PATCH v4 6/6] tests: enable virtio tests on SPAPR, Laurent Vivier, 2016/10/14
- [Qemu-ppc] [PATCH v4 3/6] tests: move QVirtioBus pointer into QVirtioDevice, Laurent Vivier, 2016/10/14