Re: [Qemu-ppc] [Qemu-devel] [PATCHv3 0/7] Improve PCI IO window orgnaization for pseries

[Laurent Vivier]

On 14/10/2016 07:41, David Gibson wrote:
> On Thu, Oct 13, 2016 at 09:10:38PM -0700, address@hidden wrote:
>> Hi,
>>
>> Your series seems to have some coding style problems. See output below for
>> more information:
> 
> So.. this one is a fairly standard false positive.  checkpatch
> complains about multiple statements in a macro when it's actually a
> macro that's supposed to expand within a data structure initializer.
> 
>> Type: series
>> Message-id: address@hidden
>> Subject: [Qemu-devel] [PATCHv3 0/7] Improve PCI IO window orgnaization for 
>> pseries
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>>
>> BASE=base
>> n=1
>> total=$(git log --oneline $BASE.. | wc -l)
>> failed=0
>>
>> # Useful git options
>> git config --local diff.renamelimit 0
>> git config --local diff.renames True
>>
>> commits="$(git log --format=%H --reverse $BASE..)"
>> for c in $commits; do
>>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
>>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
>> then
>>         failed=1
>>         echo
>>     fi
>>     n=$((n+1))
>> done
>>
>> exit $failed
>> === TEST SCRIPT END ===
>>
>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>> Switched to a new branch 'test'
>> 8fa0718 spapr: Improved placement of PCI host bridges in guest memory map
>> 6416268 spapr_pci: Add a 64-bit MMIO window
>> 94e8f4c spapr: Adjust placement of PCI host bridge to allow > 1TiB RAM
>> 692718a spapr_pci: Delegate placement of PCI host bridges to machine type
>> 2b765c9 libqos: Limit spapr-pci to 32-bit MMIO for now
>> 4543692 libqos: Correct error in PCI hole sizing for spapr
>> 2c35727 libqos: Isolate knowledge of spapr memory map to qpci_init_spapr()
>>
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/7: libqos: Isolate knowledge of spapr memory map to 
>> qpci_init_spapr()...
>> Checking PATCH 2/7: libqos: Correct error in PCI hole sizing for spapr...
>> Checking PATCH 3/7: libqos: Limit spapr-pci to 32-bit MMIO for now...
>> Checking PATCH 4/7: spapr_pci: Delegate placement of PCI host bridges to 
>> machine type...
>> Checking PATCH 5/7: spapr: Adjust placement of PCI host bridge to allow > 
>> 1TiB RAM...
>> Checking PATCH 6/7: spapr_pci: Add a 64-bit MMIO window...
>> ERROR: trailing whitespace
>> #237: FILE: include/hw/ppc/spapr.h:44:
>> +                          uint64_t *buid, hwaddr *pio, $
>>
>> total: 1 errors, 0 warnings, 170 lines checked
>>
>> Your patch has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
> 
> In attempting to follow the suggestion above, I discovered that
> checkpatch has no listed maintainer.  Maybe we should change that
> message to "if any of these errors are false positives, then too bad,
> suck it up"...
> 

You can try to report to Paolo:

./scripts/get_maintainer.pl -f scripts/checkpatch.pl
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.

Paolo Bonzini <address@hidden> (commit_signer:13/19=68%)
Markus Armbruster <address@hidden> (commit_signer:6/19=32%)
Eric Blake <address@hidden> (commit_signer:4/19=21%)
Stefan Hajnoczi <address@hidden> (commit_signer:3/19=16%)
Peter Maydell <address@hidden> (commit_signer:2/19=11%)
address@hidden (open list:All patches CC here)


Laurent