Re: [Qemu-ppc] [PATCH v4 3/3] target-ppc: tlbie/tlbivax should have global effect

[David Gibson]

On Thu, Sep 15, 2016 at 11:41:01AM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2016-09-15 at 10:25 +1000, David Gibson wrote:
> > >  void helper_booke206_tlbivax(CPUPPCState *env, target_ulong
> > address)
> > >  {
> > > -    PowerPCCPU *cpu = ppc_env_get_cpu(env);
> > > +    CPUState *cs;
> > >  
> > >      if (address & 0x4) {
> > >          /* flush all entries */
> > > @@ -2774,11 +2774,15 @@ void helper_booke206_tlbivax(CPUPPCState
> > *env, target_ulong address)
> > >      if (address & 0x8) {
> > >          /* flush TLB1 entries */
> > >          booke206_invalidate_ea_tlb(env, 1, address);
> > > -        tlb_flush(CPU(cpu), 1);
> > > +        CPU_FOREACH(cs) {
> > > +            tlb_flush(cs, 1);
> > > +        }
> > >      } else {
> > >          /* flush TLB0 entries */
> > >          booke206_invalidate_ea_tlb(env, 0, address);
> > > -        tlb_flush_page(CPU(cpu), address & MAS2_EPN_MASK);
> > > +        CPU_FOREACH(cs) {
> > > +            tlb_flush_page(cs, address & MAS2_EPN_MASK);
> > > +        }
> > 
> > Why are these explicit CPU_FOREACH()s instead of using the flags
> > you've just bui
> 
> Because we haven't converted BookE to lazy TLB flushing yet...

Ah, right.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature