Re: [Qemu-ppc] [PATCH 1/2] tests: make pc_alloc_init/init_flags/uninit generic

[Thomas Huth]

On 05.09.2016 18:48, Laurent Vivier wrote:
> 
> 
> On 05/09/2016 18:00, Thomas Huth wrote:
>> On 05.09.2016 16:38, Laurent Vivier wrote:
>>> And add support for ppc64.
>>>
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>> ---
>>>  tests/Makefile.include      |  3 ++-
>>>  tests/libqos/libqos.h       |  2 +-
>>>  tests/libqos/malloc-ppc64.c | 38 ++++++++++++++++++++++++++++++++++++++
>>>  tests/libqos/malloc-ppc64.h | 17 +++++++++++++++++
>>>  tests/libqos/malloc.c       | 42 ++++++++++++++++++++++++++++++++++++++++++
>>>  tests/libqos/malloc.h       |  3 +++
>>>  6 files changed, 103 insertions(+), 2 deletions(-)
>>>  create mode 100644 tests/libqos/malloc-ppc64.c
>>>  create mode 100644 tests/libqos/malloc-ppc64.h
>>>
>>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>>> index 14be491..a286848 100644
>>> --- a/tests/Makefile.include
>>> +++ b/tests/Makefile.include
>>> @@ -557,8 +557,9 @@ tests/test-crypto-block$(EXESUF): 
>>> tests/test-crypto-block.o $(test-crypto-obj-y)
>>>  
>>>  libqos-obj-y = tests/libqos/pci.o tests/libqos/fw_cfg.o 
>>> tests/libqos/malloc.o
>>>  libqos-obj-y += tests/libqos/i2c.o tests/libqos/libqos.o
>>> +libqos-obj-y += tests/libqos/malloc-ppc64.o tests/libqos/malloc-pc.o
>>
>> Maybe this could rather be put into a libqos-malloc-obj-y variable which
>> is then used to link these only to the tests that really need them?
> 
> Good idea.

Thinking about this again, this maybe makes the Makefile more complex
than it has to be ... so maybe it's better to keep it the way you did it
in this patch. ... your choice!

 Thomas