[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2] spar: remove extra type variable
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PATCH v2] spar: remove extra type variable |
Date: |
Tue, 9 Aug 2016 13:32:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 |
On 09.08.2016 13:15, Cédric Le Goater wrote:
> The sPAPR CPU core typename is already available in the upper
> block. Let's use it and move the check upward also.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> hw/ppc/spapr.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> Index: qemu-dgibson-for-2.8.git/hw/ppc/spapr.c
> ===================================================================
> --- qemu-dgibson-for-2.8.git.orig/hw/ppc/spapr.c
> +++ qemu-dgibson-for-2.8.git/hw/ppc/spapr.c
> @@ -1772,6 +1772,11 @@ static void ppc_spapr_init(MachineState
> if (mc->query_hotpluggable_cpus) {
> char *type = spapr_get_cpu_core_type(machine->cpu_model);
>
> + if (!object_class_by_name(type)) {
> + error_report("Unable to find sPAPR CPU Core definition");
> + exit(1);
> + }
> +
> spapr->cores = g_new0(Object *, spapr_max_cores);
> for (i = 0; i < spapr_max_cores; i++) {
> int core_id = i * smp_threads;
> @@ -1783,15 +1788,7 @@ static void ppc_spapr_init(MachineState
> qemu_register_reset(spapr_drc_reset, drc);
>
> if (i < spapr_cores) {
> - char *type = spapr_get_cpu_core_type(machine->cpu_model);
> - Object *core;
> -
> - if (!object_class_by_name(type)) {
> - error_report("Unable to find sPAPR CPU Core definition");
> - exit(1);
> - }
> -
> - core = object_new(type);
> + Object *core = object_new(type);
> object_property_set_int(core, smp_threads, "nr-threads",
> &error_fatal);
> object_property_set_int(core, core_id, CPU_CORE_PROP_CORE_ID,
>
Reviewed-by: Thomas Huth <address@hidden>