[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH v1 3/5] spapr: Implement CPUClass::get_migrati
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-ppc] [RFC PATCH v1 3/5] spapr: Implement CPUClass::get_migration_id() for PowerPC CPUs |
|
Date: |
Wed, 6 Jul 2016 22:23:34 +0530 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jul 06, 2016 at 04:35:28PM +0200, Greg Kurz wrote:
> On Wed, 6 Jul 2016 14:29:19 +0530
> Bharata B Rao <address@hidden> wrote:
> > cpu_index is used as migration_id by default. For machine type versions
> > that set use-migration-id property, cpu_dt_it is returned.
> >
>
> It looks wrong to hijack cpu_dt_id to fix migration.
>
> For pseries-2.7, you need to pass the sum of the index of the core in
> spapr->cores and the index of the thread in sc->threads.
>
> All other machines just need to pass the index of the cpu in their
> respective arrays, which happens to be equal to cs->cpu_index.
Yes, that is indeed good and simplifies things. Thanks for noting this.
Regards,
Bharata.