qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] target-ppc: Eliminate redundant and incorrect fun


From: alarson
Subject: Re: [Qemu-ppc] [PATCH] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb
Date: Sun, 26 Jun 2016 21:38:03 -0500

David Gibson <address@hidden> wrote on 06/26/2016 08:36:52 
PM:

> From: David Gibson <address@hidden>
> To: Aaron Larson <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Date: 06/26/2016 08:58 PM
> Subject: Re: [PATCH] target-ppc: Eliminate redundant and incorrect 
function booke206_page_size_to_tlb
> 
> On Fri, Jun 24, 2016 at 12:11:00PM -0700, Aaron Larson wrote:
> > 
> > Eliminate redundant and incorrect booke206_page_size_to_tlb function
> > from ppce500_spin.c in preference to previously existing but newly
> > exported definition from e500.c
> > 
> > Signed-off-by: Aaron Larson <address@hidden>
> 
> Uh.. sorry.. can you provide a reference explaining why the removed
> version is wrong?  Doesn't this depend on which MMU Architecture
> Version we're emulating?

Sure, the code is internally inconsistent (shift assumed didn't match 
shift defined).  I will provide an update commit message, similar to the 
original posting I made a few days ago with the "direction" corrected.

I didn't verify what sub-architectures/platforms are affected.  I've been 
assuming it was just ppce500.  If it is important I can do a bit of 
research, but the way code is coupled to platforms is sometimes surprising 
to me, so I'm not sure I would trust my analysis.  Let me know if you need 
this analysis as part of the updated comment.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]