[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC for-2.7 11/11] pseries: Remove unused callbacks from
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state |
Date: |
Wed, 27 Apr 2016 16:22:25 +1000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Apr 21, 2016 at 03:31:33PM +1000, Alexey Kardashevskiy wrote:
> On 04/20/2016 12:33 PM, David Gibson wrote:
> >The VIOsPAPRBus structure has some callback pointers in it which aren't
> >used anywhere in the code. It's not clear exactly why they were there in
> >the first place, but they certainly have no function now.
>
> It is clear - incorrect QOM'fication in 3954d33ab7f82f5a5 when parts of
> VIOsPAPRDeviceInfo became parts of VIOsPAPRBus, you can adjust the commit
> log :)
Thanks for the research, I'll update accordingly.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [RFC for-2.7 00/11] A new infrastructure for guest device trees, David Gibson, 2016/04/19
- [Qemu-ppc] [RFC for-2.7 03/11] pseries: Remove rtas_addr and fdt_addr fields from machinestate, David Gibson, 2016/04/19
- [Qemu-ppc] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state, David Gibson, 2016/04/19
- [Qemu-ppc] [RFC for-2.7 10/11] pseries: Consolidate construction of /rtas device tree node, David Gibson, 2016/04/19
- [Qemu-ppc] [RFC for-2.7 09/11] pseries: Consolidate construction of /chosen device tree node, David Gibson, 2016/04/19
- [Qemu-ppc] [RFC for-2.7 02/11] pseries: Split device tree construction from device tree load, David Gibson, 2016/04/19
- [Qemu-ppc] [RFC for-2.7 07/11] pseries: Move adding of fdt reserve map entries, David Gibson, 2016/04/19