[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] cuda: fix off-by-one error in SET_TIME command
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH] cuda: fix off-by-one error in SET_TIME command |
Date: |
Tue, 19 Apr 2016 11:41:50 +1000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Apr 18, 2016 at 10:07:45AM +0200, Aurelien Jarno wrote:
> With the new framework the cuda_cmd_set_time command directly receive
> the data, without the command byte. Therefore the time is stored at
> in_data[0], not at in_data[1].
>
> This fixes the "hwclock --systohc" command in a guest.
>
> Cc: Hervé Poussineau <address@hidden>
> Cc: David Gibson <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
Applied to ppc-for-2.6. I'll send a pull request shortly.
> ---
> hw/misc/macio/cuda.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c
> index c7472aa..f15f301 100644
> --- a/hw/misc/macio/cuda.c
> +++ b/hw/misc/macio/cuda.c
> @@ -685,8 +685,8 @@ static bool cuda_cmd_set_time(CUDAState *s,
> return false;
> }
>
> - ti = (((uint32_t)in_data[1]) << 24) + (((uint32_t)in_data[2]) << 16)
> - + (((uint32_t)in_data[3]) << 8) + in_data[4];
> + ti = (((uint32_t)in_data[0]) << 24) + (((uint32_t)in_data[1]) << 16)
> + + (((uint32_t)in_data[2]) << 8) + in_data[3];
> s->tick_offset = ti - (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL)
> / NANOSECONDS_PER_SECOND);
> return true;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature